Remove write_float_fast and write_std_float_fast
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found this in the git log: I must have kept the older versions around in case someone wants to use them or see how they perform. I'm sure it's fine to get rid of them. |
mjambon
reviewed
Jul 18, 2022
sim642
force-pushed
the
rm-write_float_fast
branch
from
1d7d08f to
dce2dd3
Compare
sim642
requested review from
NathanReb,
panglesd and
Leonidas-from-XIV
as code owners
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Aug 9, 2022
CHANGES: *2022-08-09* ### Added - Expanded documentation of exceptions (@sim642, ocaml-community/yojson#148) ### Removed - Removed undocumented and unused functions `write_float_fast` and `write_std_float_fast` from `Yojson`, `Yojson.Basic` and `Yojson.Safe` (@sim642, ocaml-community/yojson#149) ### Fixed - Fix out-of-bounds error occurring when parsing object field names with atdgen parsers using `map_ident` or `map_lexeme` (@mjambon, ocaml-community/yojson#150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the two unused functions according to the discussion in #148 (comment).
Notably, they are in the interface, but hidden from documentation and according to sherlocode no opam package calls them. This is unlike
write_float_precandwrite_std_float_prec, which are used by atdgen.I'm not sure of why the fast versions exist in the first place though. Could be considered related to #51, but that seems to concern another issue.
TODO