Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Use keychain APIs for OAuth credentials #9146

Closed
wants to merge 11 commits into from

Conversation

derrod
Copy link
Member

@derrod derrod commented Jun 25, 2023

Description

This is built on top of #9122 as a test/reference implementation for using the keychain APIs. It will require some rework whenever obsproject/rfcs#39 is done.

Motivation and Context

More secure credentials storage and good practice of revoking credentials once they're no longer neeed.

How Has This Been Tested?

Tested on Windows, Mac, and Linux.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod force-pushed the oauth-keychain-api branch from 7d290c0 to 40cc184 Compare June 25, 2023 02:25
@derrod derrod force-pushed the oauth-keychain-api branch from 40cc184 to 5c517f3 Compare June 30, 2023 01:43
@WizardCM WizardCM added the New Feature New feature or plugin label Jul 1, 2023
@Fenrirthviti
Copy link
Member

Since this has an open and pending RFC as a requirement, we are opting to close this until the RFC has been finalized.

The branch and discussion on implementation is welcome to take place on the RFC, and this may be reopened when the RFC is finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants