Remove obsolete Alternative instance #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralorn
changed the title
Upstream now implements an Alternative instance, so we don’t need the Orphan anymore
soficshift
reviewed
Sep 4, 2023
| @@ -34,7 +34,7 @@ library | |||
| , base >=4.12 && <5 | |||
| , bytestring >=0.10 && <0.12 | |||
| , hsyslog >=5 && <5.1 | |||
| , monad-logger >=0.3.36 && <0.4 | |||
| , monad-logger >=0.3.40 && <0.4 | |||
There was a problem hiding this comment.
Perhaps it's a good opportunity to be PVP compliant and add upper bounds on the minor version, re:
- Client defines orphan instance. If a package defines an orphan instance, it MUST depend on the minor version of the packages that define the data type and the type class to be backwards compatible. For example, build-depends: mypkg >= 2.1.1 && < 2.1.2.
There was a problem hiding this comment.
I wonder if we should just upstream the MonadPlus instance as well and get rid of the orphans altogether.
What do you think @ali-abrar ?
|
Used CPP instead to keep the instance around for older versions of monad-logger in #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream now implements an Alternative instance, so we don’t need the Orphan anymore