Allow unique's period option to take units. #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
unique-period-takes-units
branch
from
d2a97e6 to
27e958f
Compare
sorentwo
approved these changes
Oct 21, 2023
sorentwo
pushed a commit
that referenced
this pull request
Oct 26, 2023
Other parts of Oban (e.g. rate-limiting) can take a period in the form `{n, unit}`, which is missing from the unique `:period` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other parts of oban (e.g. ratelimiting) can take period in the form
{n, unit}and this is missing from the unique:periodoption, I mentioned this on the Elixir Slack a while back and was encouraged to open an issue about it but I thought I would go one better and create a PR! Totally don't mind if you'd prefer to do this yourself in a different way.