Proposal: Add Oban.json_library/0 #1213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thiamsantos Thanks for the PR and nudging us towards using the new JSON module. When Phoenix added the Our alternative strategy was to add a wrapper that delegates to the best option at compile time. |
sorentwo
added
kind:enhancement
|
@sorentwo thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir 1.18 introduced official JSON support.
This PR adds support to configure the json library used by Oban, in order to allow the use of the official JSON module.
By default Oban will keep using Jason.
The code is adapted from Phoenix.