Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when implementing the
Oban.Job.new/2
callback, specifying a list of unique fields caused a "No local return" warning:This appears related to the
Oban.Job.unique_field
type being a list type, which is then wrapped again in the@type unique_option :: {:fields, [unique_field()]} | ...
type.For consistency, I removed the list spec in the
unique_field
type rather than theunique_option
type.