Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure text and add alternative representation #90

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

c2bo
Copy link
Member

@c2bo c2bo commented Oct 20, 2024

  • fixes a small bug in the PoP examples (backslash)
  • Restructures text into 2 major parts
    • header based syntax
    • concatenated representation (<attestation jwt> ~ <attestation jwt pop>)
  • adds format & validation similar to an sd-jwt (but simpler)

Rendered version: https://drafts.oauth.net/draft-ietf-oauth-attestation-based-client-auth/c2bo/proposed-format/draft-ietf-oauth-attestation-based-client-auth.html

closes #86
closes #76
probably closes #46?

Copy link
Collaborator

@paulbastian paulbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we include that the header based syntax is a MUST implementation support?

draft-ietf-oauth-attestation-based-client-auth.md Outdated Show resolved Hide resolved
draft-ietf-oauth-attestation-based-client-auth.md Outdated Show resolved Hide resolved
draft-ietf-oauth-attestation-based-client-auth.md Outdated Show resolved Hide resolved
draft-ietf-oauth-attestation-based-client-auth.md Outdated Show resolved Hide resolved
@c2bo
Copy link
Member Author

c2bo commented Oct 21, 2024

lgtm, should we include that the header based syntax is a MUST implementation support?

I thought about language like that as well, but I don't think it really helps here. It should be in something like HAIP that profiles an ecosystem - a client will/must know what it needs to support and an AS etc. can choose depending on the ecosystem.

@c2bo c2bo mentioned this pull request Oct 21, 2024
Co-authored-by: Tobias Looker <[email protected]>
@paulbastian paulbastian merged commit 05670e6 into main Oct 21, 2024
2 checks passed
@paulbastian paulbastian deleted the c2bo/proposed-format branch October 21, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants