Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ckeditor to 4.19.0 TAO-1 #23

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: update ckeditor to 4.19.0 TAO-1 #23

wants to merge 1 commit into from

Conversation

shaveko
Copy link
Contributor

@shaveko shaveko commented Jun 22, 2022

Update of ckeditor version to 4.19.0 TAO-1

(oat-sa/ckeditor-dev#28)

@shaveko shaveko requested review from marpesia and bziondik June 22, 2022 12:52
marpesia
marpesia approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@marpesia marpesia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Load new version and no error on the console

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marpesia marpesia marpesia approved these changes

@bziondik bziondik Awaiting requested review from bziondik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaveko @marpesia