Feat/aut 3705/update item qti identifer #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
bugalot,
pnal,
julien-sebire,
Karol-Stelmaczonek and
viktar-dzmitryieu-tao
Karol-Stelmaczonek
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
pnal
reviewed
Jul 2, 2024
| @@ -228,7 +228,7 @@ public function __construct($identifier, $title, $timeDependent, $lang = '') | |||
| */ | |||
| public function setIdentifier($identifier): void | |||
| { | |||
| if (Format::isIdentifier($identifier, false)) { | |||
| if (Format::isNormalizedString($identifier)) { | |||
There was a problem hiding this comment.
should we allow spaces in an identifier?
There was a problem hiding this comment.
It is not forbidden by QTI standard.
pnal
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using digits for item identifier