feat: Add prefix functionality for redis presistance #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaraslau-kavaliou
force-pushed
the
feat/REL-1637/redis-prefix
branch
2 times, most recently
from
6143c3e to
c6771fc
Compare
yaraslau-kavaliou
force-pushed
the
feat/REL-1637/redis-prefix
branch
3 times, most recently
from
88b2afc to
580d49d
Compare
yaraslau-kavaliou
force-pushed
the
feat/REL-1637/redis-prefix
branch
from
580d49d to
1efb456
Compare
augustas
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Works well for me. I would rather see the default prefix separator to be a single colon :, since the default redis browser that we use expects it, and it is kind of used in our other applications like that.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
yaraslau-kavaliou
force-pushed
the
feat/REL-1637/redis-prefix
branch
from
2fc249e to
ed870cd
Compare
Version
There are 0 BREAKING CHANGE, 2 features, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - https://oat-sa.atlassian.net/browse/REL-1637
Connected to - https://github.com/oat-sa/extension-tao-deliver-connect/pull/215
Prefix support has been added to the redis driver