Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decrease query count by cacheing some RDF property fields #1095

Conversation

mccar
Copy link
Contributor

@mccar mccar commented Dec 12, 2023

Fix: Added missing use Iterator in namespaced code.

Copy link
Contributor

@pribi pribi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in local devel environment.

@mccar mccar changed the base branch from master to develop December 12, 2023 11:20
@mccar mccar merged commit 3cac123 into develop Dec 12, 2023
1 of 2 checks passed
@mccar mccar deleted the feat/REL-1279/decrease-query-count-by-caching-some-rdf-property-fields-fix branch December 12, 2023 11:23
class PropertyCache
use Iterator;

class PropertyCaches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change PropertyCache to PropertyCaches?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants