chore: optimize PHP code to be faster

oat-sa · Oct 19, 2023 · b76f052 · b76f052
1 parent e077b8d
commit b76f052
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/core/kernel/persistence/smoothsql/class.Resource.php b/core/kernel/persistence/smoothsql/class.Resource.php
@@ -159,8 +159,10 @@ public function getClassesResourceIds(array $classIds): array
             return [];
         }
 
-        $inQuery = implode(',', array_fill(0, count($classIds), '?'));
-        $query = "SELECT subject, object FROM statements WHERE predicate IN (?, ?) AND object IN ($inQuery)";
+        $query = sprintf(
+            'SELECT subject, object FROM statements WHERE predicate IN (?, ?) AND object IN (%s)',
+            implode(',', array_fill(0, count($classIds), '?'))
+        );
 
         $statement = $this->getPersistence()->query(
             $query,
@@ -174,12 +176,11 @@ public function getClassesResourceIds(array $classIds): array
         $results = $statement->fetchAll();
         $resourceIds = [];
 
-        foreach ($classIds as $classId) {
-            /**
-             * @TODO FIXME Better filter it instead of go through all results every time
-             */
-            $resources = array_filter($results, static fn (array $result): bool => $result['object'] === $classId);
-            $resourceIds[$classId] = array_column($resources, 'subject');
+        foreach ($results as $result) {
+            $resourceId = $result['subject'];
+            $classId = $result['object'];
+            $resourceIds[$classId] = $resourceIds[$classId] ?? [];
+            $resourceIds[$classId][] = $resourceId;
         }
 
         return $resourceIds;