Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Assessment Title as Label when no metadata included #2535

Merged

Conversation

bartlomiejmarszal
Copy link
Contributor

@bartlomiejmarszal bartlomiejmarszal commented Nov 25, 2024

For legacy QTI Packages without metadata import process was failing due to missing label. Fix is introducing usage of assessment title to define label for imported resource.

Copy link

github-actions bot commented Nov 25, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
709 709 0 0

Copy link
Contributor

@tikhanovichA tikhanovichA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for the fix

models/classes/class.QtiTestService.php Outdated Show resolved Hide resolved
models/classes/class.QtiTestService.php Outdated Show resolved Hide resolved
models/classes/class.QtiTestService.php Outdated Show resolved Hide resolved
Copy link

Version

Target Version 48.14.3
Last version 48.14.2

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

Copy link
Contributor

@shpran shpran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job! 👍🏻

@bartlomiejmarszal bartlomiejmarszal merged commit 0b4ca1e into develop Nov 25, 2024
5 checks passed
@bartlomiejmarszal bartlomiejmarszal deleted the fix/when-no-metadata-get-label-from-assesment-title branch November 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants