-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/AUT-3414/Align categories that activate the TextToSpeech tool #2461
Conversation
…eep only the main one when updating
Front-end summary Node 18
|
Version
There are 0 BREAKING CHANGE, 2 features, 0 fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the code, @jsconan
I did a check on PHP code level only and looks good. We can have a demo to check functionality if possible.
- New code is covered by tests (if applicable) JS code is
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Related to: https://oat-sa.atlassian.net/browse/AUT-3414
Requires:
Summary
Add support for multiple categories to activate presets in the test authoring.
The concepts is as follows:
The main example for this is the text-to-speech tool which used to be activated using the category
x-tao-option-textToSpeech
. However, TAO Advance expects it to bex-tao-option-tts
. Both categories will be supported, but only the later will be kept when updating a test.How to test
Prerequisite: have the extension taoTextHelp installed with the branch
feature/AUT-3414/align-tts-category
x-tao-option-textToSpeech
is set appropriatelygit checkout -t origin/feature/AUT-3414/align-tts-category
x-tao-option-tts
is set appropriately