Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve opening another tab with new session with the same user #2456

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

tikhanovichA
Copy link
Contributor

https://oat-sa.atlassian.net/browse/INF-266

For cases when one of sessions was finished and then reopened, the pausing for another tabs worked not like expected.

How to test:

  1. Start new test A (new LTI link)
  2. Start new test B (new LTI link)
  3. A gets the “concurrent test” popup. Do not click on it
  4. Finish test B
  5. Check that you have “Thank you” page
  6. Go back to test A & Accept the popup
  7. Check that you have “Test suspended” page
  8. Start the previous test A again (reusing the previous LTI link). This unpauses A
  9. Start the previous test B again (reusing the previous LTI link). This pauses A
  10. Go back to test A & Accept the popup
  11. You should receive the “Test suspended” page
Screen.Recording.2024-04-12.at.08.59.03.mov

Copy link

github-actions bot commented Apr 12, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
708 708 0 0

Co-authored-by: Héctor Arroyo <[email protected]>
Signed-off-by: Aleksej Tikhanovich <[email protected]>
@tikhanovichA tikhanovichA requested a review from hectoras April 16, 2024 07:27
@tikhanovichA tikhanovichA requested a review from hectoras April 16, 2024 11:04
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tikhanovichA

If possible, can we add a test case with the new code implement?

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

Version

❕ Some commits are not using the conventional commits formats. They will be ignored in version management.

Target Version 48.4.1
Last version 48.4.0

There are 0 BREAKING CHANGE, 0 feature, 5 fixes

@tikhanovichA tikhanovichA merged commit c65ea7c into develop Apr 23, 2024
5 checks passed
@tikhanovichA tikhanovichA deleted the fix/INF-266/open-new-session-in-another-tab branch April 23, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants