fix: feature flag for xml editor #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2418 +/- ##
=============================================
+ Coverage 16.94% 16.96% +0.01%
- Complexity 3203 3204 +1
=============================================
Files 208 208
Lines 11542 11543 +1
=============================================
+ Hits 1956 1958 +2
+ Misses 9586 9585 -1 ☔ View full report in Codecov by Sentry. |
yaraslau-kavaliou
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
- New code is covered by tests
- Tests are running successfully on my local machine
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Looks good and works locally after existing env update and for fresh installation
augustas
approved these changes
Dec 6, 2023
Version
There are 0 BREAKING CHANGE, 0 feature, 13 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket - https://oat-sa.atlassian.net/browse/REL-1343
Goal
Create a new feature flag that unlocks this xml editor feature, so that we could enable it by changing environment variable secret
Changelog
How to test
docker exec -it {CONTAINER_NAME} php index.php 'oat\tao\scripts\tools\FeatureFlag\FeatureFlagTool' -s FEATURE_FLAG_XML_EDITOR_ENABLED -v true