Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add manifest in export test options #2415

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

bartlomiejmarszal
Copy link
Contributor

How to reproduce:

  1. Create new class
  2. Import or create tests inside of class
  3. Export class
  4. Download file

Expected behaviour:
All tests are imported into class

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ad8355a) 16.71% compared to head (4329e37) 16.70%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2415      +/-   ##
=============================================
- Coverage      16.71%   16.70%   -0.01%     
- Complexity      3182     3183       +1     
=============================================
  Files            207      207              
  Lines          11453    11456       +3     
=============================================
  Hits            1914     1914              
- Misses          9539     9542       +3     
Files Coverage Δ
...es/export/Formats/Package2p1/TestPackageExport.php 0.00% <0.00%> (ø)
...es/export/Formats/Package2p2/TestPackageExport.php 14.28% <0.00%> (ø)
models/classes/export/AbstractQtiTestExporter.php 0.00% <0.00%> (ø)
models/classes/export/AbstractTestExport.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartlomiejmarszal bartlomiejmarszal self-assigned this Nov 6, 2023
Copy link
Contributor

@pnal pnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

github-actions bot commented Nov 6, 2023

Version

Target Version 47.4.1
Last version 47.4.0

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

Copy link

@pribi pribi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@bartlomiejmarszal bartlomiejmarszal merged commit 90a0518 into develop Nov 6, 2023
4 checks passed
@bartlomiejmarszal bartlomiejmarszal deleted the fix/ADF-1327/export-tests-from-class branch November 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants