Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded compilation to version 2.2. #1901

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Hardcoded compilation to version 2.2. #1901

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1091be8
Hardcoded compilation to version 2.2.
julien-sebire Aug 5, 2020
6e0dc2a
Added QTI version as a constant.
julien-sebire Aug 19, 2020
9a837ea
Merge branch 'develop' into feature/MS-152/compile-qti-22
julien-sebire Aug 19, 2020
7b88e35
Required extension-tao-itemqti with compilation version 2.2 and bumpe…
julien-sebire Aug 19, 2020
05021b9
Added new QTI Compact versions to tests.
julien-sebire Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/classes/class.QtiTestCompiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ protected function compactTest()
$resolver = new taoQtiTest_helpers_ItemResolver(Service::singleton());
$originalDoc = $testService->getDoc($test);

$compiledDoc = XmlCompactDocument::createFromXmlAssessmentTestDocument($originalDoc, $resolver, $resolver);
$compiledDoc = XmlCompactDocument::createFromXmlAssessmentTestDocument($originalDoc, $resolver, $resolver, '2.2');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would go for a constant that will describe the new added value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a constant.

common_Logger::t("QTI Test XML transformed in a compact version.");

return $compiledDoc;
Expand Down