fix: code review

oat-sa · Dec 6, 2023 · 3b923a9 · 3b923a9
1 parent 18a4ac2
commit 3b923a9
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/helpers/class.TestSession.php b/helpers/class.TestSession.php
@@ -832,10 +832,14 @@ private function triggerResultTestVariablesTransmissionEvent(
 
     public function attachToTransmissionEvent(ResultTestVariablesTransmissionEvent $event): void
     {
-        $scoreTotal = array_filter($event->getVariables(), function ($item) {
-            return $item->getIdentifier() === 'SCORE_TOTAL';
-        })[0];
-        if ($scoreTotal === null) {
+        $scoreTotal = array_filter(
+            $event->getVariables(),
+            function ($item) {
+                return $item->getIdentifier() === 'SCORE_TOTAL';
+            }
+        );
+
+        if (empty($scoreTotal)) {
             return;
         }
         $outcomeVariables = $this->getResultsStorage()->getDeliveryVariables($event->getDeliveryExecutionId());
@@ -851,10 +855,11 @@ private function isManualScored(): bool
         /** @var AssessmentItemRef $itemRef */
         foreach ($this->getRoute()->getAssessmentItemRefs() as $itemRef) {
             foreach ($itemRef->getComponents() as $component) {
-                if ($component instanceof OutcomeDeclaration) {
-                    if ($component->isExternallyScored()) {
-                        return true;
-                    }
+                if (
+                    $component instanceof OutcomeDeclaration
+                    && $component->isExternallyScored()
+                ) {
+                    return true;
                 }
             }
         }