Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom config for testing PHP-MD codesize rules in the pipelines #501

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

hectoras
Copy link
Contributor

@hectoras hectoras commented Dec 11, 2023

Associated Jira issue: ADF-1444

DO NOT MERGE (yet).

For testing/debugging purposes.

This is testing changes from oat-sa/tao-extension-ci-action#11

TODO:

@@ -21,7 +21,7 @@ jobs:

steps:
- name: CI
uses: oat-sa/tao-extension-ci-action@v1
uses: oat-sa/tao-extension-ci-action@experimental/phpmd-ci-checks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update with released version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please, lets still use @v1 and follow instructions on README.md, so it is automatically used by any other extension

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just revert this file and PR, we do not need this PR at all (just for testings)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, this was done so I was able to test it while I was working on the changes in the ci action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change we may want to keep is the custom ruleset I'm adding for tao mediamanager

@hectoras hectoras requested a review from gabrielfs7 December 12, 2023 11:45
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@hectoras hectoras requested a review from shpran December 12, 2023 14:54
@hectoras hectoras force-pushed the experimental/phpmd-ci-checks branch 4 times, most recently from 42aef2f to fa4d8c8 Compare December 15, 2023 15:33
@hectoras hectoras force-pushed the experimental/phpmd-ci-checks branch 5 times, most recently from 5fff645 to edc4517 Compare December 21, 2023 15:44
@hectoras hectoras force-pushed the experimental/phpmd-ci-checks branch from edc4517 to 96c1d8a Compare December 21, 2023 15:57
@hectoras hectoras force-pushed the experimental/phpmd-ci-checks branch from 96c1d8a to 8890660 Compare December 21, 2023 16:00
Copy link

Version

Target Version 12.42.0
Last version 12.41.0

There are 0 BREAKING CHANGE, 2 features, 0 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants