-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom config for testing PHP-MD codesize rules in the pipelines #501
base: develop
Are you sure you want to change the base?
Conversation
@@ -21,7 +21,7 @@ jobs: | |||
|
|||
steps: | |||
- name: CI | |||
uses: oat-sa/tao-extension-ci-action@v1 | |||
uses: oat-sa/tao-extension-ci-action@experimental/phpmd-ci-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update with released version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, lets still use @v1 and follow instructions on README.md, so it is automatically used by any other extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just revert this file and PR, we do not need this PR at all (just for testings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, this was done so I was able to test it while I was working on the changes in the ci action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change we may want to keep is the custom ruleset I'm adding for tao mediamanager
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
42aef2f
to
fa4d8c8
Compare
5fff645
to
edc4517
Compare
edc4517
to
96c1d8a
Compare
96c1d8a
to
8890660
Compare
Version
There are 0 BREAKING CHANGE, 2 features, 0 fix |
Associated Jira issue: ADF-1444
DO NOT MERGE (yet).
For testing/debugging purposes.
This is testing changes from oat-sa/tao-extension-ci-action#11
TODO:
v1
once changes in ci-action are released