fix: pci filename is used as identifier, not path #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Front-end summary Node 18
|
progys
reviewed
Jan 9, 2025
| @@ -145,7 +145,7 @@ private function getAll() | |||
|
|
|||
| foreach ($contents as $file) { | |||
| if ($file['type'] === 'file') { | |||
| $identifier = $file['path']; | |||
| $identifier = basename($file['path']); | |||
There was a problem hiding this comment.
Yeah I agree, this class is tested by integration test, but we don't run them automatically and they are neglected and failing. For this particular case vendor/bin/phpunit taoQtiItem/test/integration/portableElement/PortableElementServiceTest.php --bootstrap generis/test/bootstrap.php would have shown this issue
vbyndych
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
mccar
approved these changes
Jan 9, 2025
oatymart
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in PCI listing.
PCI filename should be used as identifier, not full path.
How to test