-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle import of props without metadata #2641
Merged
Karol-Stelmaczonek
merged 6 commits into
develop
from
bugfix/AUT-3992-no-metadata-import
Dec 6, 2024
Merged
fix: handle import of props without metadata #2641
Karol-Stelmaczonek
merged 6 commits into
develop
from
bugfix/AUT-3992-no-metadata-import
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karol-Stelmaczonek
requested review from
a team,
tikhanovichA,
bartlomiejmarszal,
KirylHatalski,
pnal and
viktar-dzmitryieu-tao
and removed request for
a team
December 4, 2024 13:50
pnal
reviewed
Dec 4, 2024
pnal
approved these changes
Dec 4, 2024
tikhanovichA
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add method unit test?\oat\taoQtiItem\test\unit\model\qti\metadata\importer\MetaMetadataImportMapperTest
test/unit/model/qti/metadata/importer/MetaMetadataImportMapperTest.php
Outdated
Show resolved
Hide resolved
bartlomiejmarszal
approved these changes
Dec 4, 2024
KirylHatalski
approved these changes
Dec 4, 2024
Front-end summary Node 18
|
Version
There are 0 BREAKING CHANGE, 1 feature, 3 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/AUT-3992
What's Changed
Dependencies PRs
How to test
Video
Screenshare.-.2024-12-04.2_17_42.PM.mp4