chore: new logic for minMax component: min value can be 0 #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
olga-kulish
reviewed
Nov 11, 2024
…type; support negative value for min
…ss getLowerThreshold
olga-kulish
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Good job!
It seems to behave as expected (still, please check comments), and there seems to be no regressions with this UI component (though I checked only a couple of interactions).
In published test, score is calculated, and seems like it's correctly limited to upperBound/lowerBound (with negative and or/float numbers)
olga-kulish
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Works well, good job!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 0 feature, 7 fixes |
Input width updated
|
oatymart
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/AUT-1389
Separate zero and disabled states in minMax component
Changes:
Nagranie.z.ekranu.2024-11-7.o.16.27.50.mov