Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.5.8 #341

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Release 8.5.8 #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f919c8
fix: wrong use of a lodash v4 API
jsconan Nov 7, 2024
b47cbef
Merge pull request #340 from oat-sa/fix/LSI-5044/runtime-error-in-dia…
jsconan Nov 8, 2024
9723a5c
chore: bundle assets
invalid-email-address Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion views/js/loader/diagnostic.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion views/js/loader/diagnostic.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion views/js/loader/taoClientDiagnostic.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion views/js/loader/taoClientDiagnostic.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 5 additions & 7 deletions views/js/tools/diagnostic/diagnostic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright (c) 2016-2021 (original work) Open Assessment Technologies SA ;
* Copyright (c) 2016-2024 (original work) Open Assessment Technologies SA ;
*/
define([
'jquery',
Expand All @@ -40,7 +40,7 @@ define([
'tpl!taoClientDiagnostic/tools/diagnostic/tpl/feedback',
'tpl!taoClientDiagnostic/tools/diagnostic/tpl/quality-bar',
'css!taoClientDiagnosticCss/diagnostics'
], function(
], function (
$,
_,
__,
Expand Down Expand Up @@ -418,7 +418,7 @@ define([
// launch each testers in series, then display the results
async.series(testers, () => {
// pick the lowest percentage as the main score
const total = _.minBy(scores, 'globalPercentage');
const total = _.minBy(Object.values(scores), 'globalPercentage');

// get a status according to the main score
const status = getStatus(total.globalPercentage, _thresholds);
Expand Down Expand Up @@ -631,7 +631,7 @@ define([
* @private
*/
function toggleFields(state) {
_.forEach(fields, function(fieldName) {
_.forEach(fields, function (fieldName) {
toggleControl(fieldName, state);
});
}
Expand Down Expand Up @@ -696,9 +696,7 @@ define([
{}
);

this.changeStatus(__('Getting school name...'))
.cleanUp()
.disable();
this.changeStatus(__('Getting school name...')).cleanUp().disable();

if (_.isFunction(validate)) {
validate(values)
Expand Down
Loading