Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/INV-707/2023.05/Broken tooltip #145

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 30, 2023

Related to: https://oat-sa.atlassian.net/browse/INV-707

Backport of #144

Summary

Restore the tooltip helper in the textReader PCI.

image
image

Also:

  • make sure it works with TAO Advance.
  • fix the tooltip not showing up in the item authoring preview.

Details

When migrating the PCI to the IMS standard, we made some surgery to remove or adapt incompatible code. However, it was a tad too aggressive, and the helper responsible for preparing the tooltip was removed together with the one that brought MathJAX.

How to test

  • install TAO with the extension pciSamples from tao-community v2023.05.4
  • check out the branch
  • update TAO
  • have an item with the textReader PCI and some tooltips (you can use the ones attached to the ticket)
  • publish a delivery (or pick up an existing one if any
  • take the test and check the tooltip works

@jsconan jsconan merged commit 2c16b9b into release-3.7.0.0.1 Nov 22, 2023
@jsconan jsconan deleted the hotfix/INV-707/2023.05/broken-tooltip branch November 22, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant