Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix popup ui bug #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix popup ui bug #125

wants to merge 2 commits into from

Conversation

lvshaoping007
Copy link
Contributor

@lvshaoping007 lvshaoping007 commented Sep 8, 2021 •
edited
Loading

#120
fix popup route ui bug . contains

LoginPage-bootom desc
CreatePasswordPage-bottom button
HomePage-bottom tab
AccountManagePage-bottom button

LoginPage-bootom desc

image

CreatePasswordPage-bottom button

image

HomePage-bottom tab

image
image
image

AccountManagePage-bottom button

image

@peterjgilbert
Copy link
Contributor

peterjgilbert commented Sep 8, 2021 •
edited
Loading

@lvshaoping007 do you mind attaching a screenshot to show the updated layout?

@pro-wh
Copy link
Contributor

pro-wh commented Sep 8, 2021

I'll be proposing a shorter term fix that enlarges the persistent window to fix the current UI as it is before this change.

I'm not opposed to moving toward a more fluid layout in the longer term though.

We'd also like to cherry-pick the centering fix for this first release.

@pro-wh pro-wh mentioned this pull request Sep 8, 2021
Merged
@sugarT365
Copy link

@lvshaoping007 do you mind attaching a screenshot to show the updated layout?

ok ，i will show the screenshot here

@lvshaoping007 lvshaoping007 force-pushed the loginPageFix branch 2 times, most recently from ad3cf7f to 2003916 Compare September 9, 2021 03:15
@lvshaoping007
Copy link
Contributor Author

i revert the logo center change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko Awaiting requested review from kostko kostko is a code owner

@lukaw3d lukaw3d Awaiting requested review from lukaw3d lukaw3d is a code owner

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@tjanez tjanez Awaiting requested review from tjanez tjanez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvshaoping007 @peterjgilbert @pro-wh @sugarT365