Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/actions/hash-rust: Add features parameter #1948

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Aug 23, 2024

Straight forward implementation of #1947. Passing empty features, e.g. --features "" works perfectly fine.

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for oasisprotocol-oasis-sdk canceled.

Name Link
🔨 Latest commit 182b1b3
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/66cf153a553d0b0008d01828

@matevz matevz force-pushed the matevz/features/actions-features-flag branch from 69962f7 to b87fc79 Compare August 23, 2024 10:01
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.25%. Comparing base (f18d394) to head (182b1b3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   60.75%   59.25%   -1.51%     
==========================================
  Files         130      129       -1     
  Lines        9585     9583       -2     
==========================================
- Hits         5823     5678     -145     
- Misses       3762     3905     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matevz matevz self-assigned this Aug 23, 2024
@matevz matevz force-pushed the matevz/features/actions-features-flag branch from b87fc79 to 182b1b3 Compare August 28, 2024 12:16
@matevz matevz merged commit 22b8922 into main Aug 29, 2024
28 of 29 checks passed
@matevz matevz deleted the matevz/features/actions-features-flag branch August 29, 2024 13:32
github-actions bot added a commit that referenced this pull request Aug 29, 2024
…atevz/features/actions-features-flag

.github/actions/hash-rust: Add features parameter 22b8922
github-actions bot added a commit that referenced this pull request Aug 29, 2024
…/matevz/features/actions-features-flag

.github/actions/hash-rust: Add features parameter 22b8922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants