feat(cmd/rofl): Add --verify to build to verify enclave identities #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
kostko
force-pushed
the
kostko/feature/rofl-build-verify
branch
from
b3e169b to
3761e35
Compare
kostko
force-pushed
the
kostko/feature/rofl-build-verify
branch
from
3761e35 to
a619696
Compare
matevz
reviewed
Jan 24, 2025
| } | ||
|
|
||
| if !maps.Equal(buildEnclaves, manifestEnclaves) { | ||
| fmt.Println("Built enclave identities DIFFER from manifest enclave identities!") |
There was a problem hiding this comment.
Can you also print out the build enclave ID and the one that is in manifest file?
matevz
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to audit apps.