Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CI to make dependent workflows visible. #685

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Jul 25, 2024

Unfortunately, GitHub Actions has limited support of the inter-workflow dependencies spread across multiple files.
That is why we move tests and NPM publishing into a single workflow file.

image

@shimkiv shimkiv requested a review from ymekuria July 25, 2024 08:34
@shimkiv shimkiv self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (91f4ee8) to head (759863e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #685   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1487      1487           
  Branches       310       310           
=========================================
  Hits          1487      1487           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shimkiv shimkiv merged commit c2e6154 into main Jul 25, 2024
18 checks passed
@shimkiv shimkiv deleted the hot-fix/ci-sequencing branch July 25, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants