Abstract over the specific Constraint.t type used by the backing constraint system
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing the base branch to master. It seems it is not doing automatically. GH having some issues? |
dannywillems
changed the base branch from
feature/abstract-run-state
to
master
dannywillems
reviewed
Jan 7, 2025
| @@ -64,22 +64,15 @@ module type S = sig | |||
| module Constraint : sig | |||
| type t = (Cvar.t, Field.t) Constraint.t [@@deriving sexp] | |||
|
|
|||
| type 'k with_constraint_args = ?label:string -> 'k | |||
| val boolean : Cvar.t -> t | |||
There was a problem hiding this comment.
Ah, I thought we were using it everywhere in Pickles.
dannywillems
approved these changes
Jan 7, 2025
|
Context clearer now. We want to avoid mixing constraints from different backends too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #858, delivering on a large part of the promise of previous iterations: this allows us to define a constraint-system-specific constraint enum instead of overloading the snarky one. In particular, this gives the ability to have safe rust FFI types for constraint system generation, by only allowing the specific constraints that it supports.
As part of the pre-work that built up to this, we have also ensured that a
Typ.tfor any particular constraint definition is compatible with only the constraint systems that support it, ensuring that we get better type safety for OCaml / JS too.