Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting variants of SHA2 #1957

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Supporting variants of SHA2 #1957

wants to merge 36 commits into from

Conversation

querolita
Copy link
Member

Closes #1941

@querolita
clarify sha2 or sha3 in examples
eb5fa81
@querolita
bytes conversion for UInt64
ff313c6
@querolita
constants for sha2 variants
d040fdc
@querolita
preliminary sha2 interface
ff1ff4d
@querolita
padding function for short and long sha2
b31edda
@querolita
generic message schedule function
8847397
@querolita
infer flag from instanceof generic T to avoid passing is_short
a72e52c
@querolita
compression function and auxiliary subroutines from sha256 module
9c5e988
@querolita
different parameters for sigma function depending on variant
98be5f2
@querolita
generic compression function
3b6c837
@querolita
auxiliary functions for reduction modulo 32 64 bits to reduce number …
9f001b1 
…of lines
@querolita
adapt auxiliary functions for generic case
1bde951
@querolita
prettify and sigma for 256 and 512
62c4ae5
@querolita
truncate for 224 and 384 variants
5f4527a
@querolita
remove length property
854cb19
@querolita
unit tests for sha2
086f927
@querolita
undo name change
4f40f97
@querolita
Merge branch 'main' into feature/eddsa/sha512
9dd0ff6
@querolita
Merge branch 'main' into feature/eddsa/sha512
d18716d
@querolita
Merge branch 'main' into feature/eddsa/sha512
a9a3668
@querolita
remove unused web3 type import
924bb8f
@querolita
pass flag because ts cannot infer types from runtime values
0b934e7
@querolita
refactor constants
d2fef76
@querolita
pass length to functions to improve readability
47e12da
@querolita
fix switch syntax
06afc51
@querolita
fix aliases for sha3 vs sha2
40482ee
@querolita
update changelog
b885ddc
@querolita
Merge branch 'main' into feature/eddsa/sha512
86da703
@querolita
Merge remote-tracking branch 'origin/feature/eddsa/sha512' into featu…
a2bc7ec 
…re/eddsa/sha512
@querolita
update bindings commit
a6163d7
@querolita querolita marked this pull request as ready for review January 10, 2025 15:29
@querolita querolita requested review from a team as code owners January 10, 2025 15:29
Geometer1729
Geometer1729 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Geometer1729 Geometer1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometer1729 Geometer1729 Geometer1729 approved these changes

@hattyhattington17 hattyhattington17 Awaiting requested review from hattyhattington17 hattyhattington17 is a code owner automatically assigned from o1-labs/exploration-team

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sha2-512
3 participants
@querolita @Geometer1729 @Trivo25