feature: CancellationToken-based shutdowns
#5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
approved these changes
Jan 10, 2025
| @@ -447,6 +448,10 @@ impl NymNode { | |||
| wireguard: Some(wireguard_data), | |||
| config, | |||
| accepted_operator_terms_and_conditions: false, | |||
| shutdown_manager: ShutdownManager::new("NymNode") | |||
There was a problem hiding this comment.
Is there a reason why this one PascalCase while the others are kebab-case?
There was a problem hiding this comment.
I'm not sure I've been particularly consistent, but I think with recent changes I attempted to use PascalCase for the top level name and kebab-case or snake_case for any child components
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
i think it would have to be dealt with on case-by-case basis, because with those changes on-drop behaviour is explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR introduces scaffolding for using
CancellationTokenandTaskTrackerfor our graceful shutdowns rather than the existingTaskClientandTaskManager.it focues on creating the new API and migrating some of the existing tasks inside
NymNodeThis change is