-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: nym topology revamp #5271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
force-pushed
the
feature/smooshed-nodes-compat-vol2
branch
from
December 16, 2024 17:45
ff2f646
to
65e8a67
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
jstuczyn
force-pushed
the
feature/smooshed-nodes-compat-vol2
branch
2 times, most recently
from
December 17, 2024 09:49
890b9ee
to
47d72f7
Compare
…ting on non-linux targets
jstuczyn
force-pushed
the
feature/smooshed-nodes-compat-vol2
branch
from
December 17, 2024 09:56
47d72f7
to
8b0629d
Compare
octol
approved these changes
Dec 18, 2024
The majority of the test cases have been preceded by #5388. Topology behaviour and regression is all passing and working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes the internals of the
NymTopology
to blur the lines between explicit mixnodes and gateways so that what used to be considered a "mixnode" could be a valid egress point of the network.NymTopology
is no longer divided intoBTreeMap<MixLayer, Vec<mix::Node>>
andVec<gateway::Node>
. instead there's information about the current rewarded set (to support future VRF work) and a simple map ofHashMap<NodeId, RoutingNode>
.the new features are mostly controlled via 2 new flags/config values:
use_extended_topology
that tells the client to retrieve all network nodes rather than the ones that got assigned "active" mixnode role (or support being a gateway)ignore_egress_epoch_role
that tells the client it's fine to construct egress packets to nodes that are not assigned entry or exit gateway roleThis change is