Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: nym topology revamp #5271

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Dec 16, 2024

this PR changes the internals of the NymTopology to blur the lines between explicit mixnodes and gateways so that what used to be considered a "mixnode" could be a valid egress point of the network.

NymTopology is no longer divided into BTreeMap<MixLayer, Vec<mix::Node>> and Vec<gateway::Node>. instead there's information about the current rewarded set (to support future VRF work) and a simple map of HashMap<NodeId, RoutingNode>.

the new features are mostly controlled via 2 new flags/config values:

  • use_extended_topology that tells the client to retrieve all network nodes rather than the ones that got assigned "active" mixnode role (or support being a gateway)
  • ignore_egress_epoch_role that tells the client it's fine to construct egress packets to nodes that are not assigned entry or exit gateway role

This change is Reviewable

@jstuczyn jstuczyn added this to the Hu milestone Dec 16, 2024
@jstuczyn jstuczyn requested a review from octol as a code owner December 16, 2024 17:42
@jstuczyn jstuczyn force-pushed the feature/smooshed-nodes-compat-vol2 branch from ff2f646 to 65e8a67 Compare December 16, 2024 17:45
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:57am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 9:57am

@jstuczyn jstuczyn force-pushed the feature/smooshed-nodes-compat-vol2 branch 2 times, most recently from 890b9ee to 47d72f7 Compare December 17, 2024 09:49
@jstuczyn jstuczyn merged commit a2322d6 into develop Dec 19, 2024
16 checks passed
@jstuczyn jstuczyn deleted the feature/smooshed-nodes-compat-vol2 branch December 19, 2024 10:44
@benedettadavico
Copy link
Contributor

The majority of the test cases have been preceded by #5388.

Topology behaviour and regression is all passing and working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants