Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-api-client: deduplicate code #5267

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

octol
Copy link
Contributor

@octol octol commented Dec 16, 2024

After adding PATCH support in #5260, it's now time to deduplicate some of the code

This change is Reviewable

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 8:02am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 8:02am

Base automatically changed from jon/add-patch-to-http-api-client to develop December 16, 2024 11:28
@octol octol force-pushed the jon/deduplicate-http-api-client branch from ea9c767 to 20a6034 Compare December 16, 2024 11:29
@octol octol marked this pull request as ready for review December 16, 2024 11:29
@octol octol modified the milestones: Reeses, Hu Dec 16, 2024
@octol octol force-pushed the jon/deduplicate-http-api-client branch from 20a6034 to 8708e97 Compare December 18, 2024 08:01
@octol octol merged commit d03302c into develop Dec 18, 2024
18 checks passed
@octol octol deleted the jon/deduplicate-http-api-client branch December 18, 2024 11:36
@tommyv1987
Copy link
Contributor

Overview: http-api-client: Deduplicate Code

This change simplifies the client by consolidating HTTP methods into unified functions, reducing redundancy and improving maintainability. PATCH support is retained, and all tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants