Fix write size #399
Merged
Fix write size #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2023 10:47
This reverts commit de317f5. The upcoming patch will fix the issue more straight forward. Signed-off-by: Marco Felsch <[email protected]>
Since commit 3f512a6 ("libuuu: hidreport: fix write size for Windows") it may happen that the memcpy() does read outside the provided memory. Fix this by moving the Windows HIDAPI workaround behind the memcpy(), here no overflows can happen since the m_out_buff size is at least m_size_out. Signed-off-by: Marco Felsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the right size without introducing a 2nd parameter for this to make the code a bit cleaner.