Fixed windows icon replacement by changing the build order #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was having the same issues as @bastimeyer. Can confirm this fixed it for me also. |
|
This fixes it for me too. 👍 Please accept the pull request :-) |
|
@steffenmllr Please merge this! |
|
So is there an issue with the pull request or is everyone on vacation? 😞 |
|
Sorry guys. I've been out of town for work. Let's do this. |
gabepaez
added a commit
that referenced
this pull request
Sep 6, 2014
Fixed windows icon replacement by changing the build order
|
Just published |
thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already described in issue #44, I was having some build issues on windows with the switch over to resourcer. For some reason (I still haven't figured it out why) resourcer removes the appended app content of the exe file, which results in a blank node-webkit application after replacing the windows icon. The simple solution for me was changing the build order, so that the app content gets appended afterwards.