Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind application volume adjustment gestures #17634

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Unbind application volume adjustment gestures #17634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b5d605
Unbind apps volume gestures and reflect that they're unbound in the c…
SaschaCowley Jan 21, 2025
1ca666b
Update change log with new PR
SaschaCowley Jan 21, 2025
4043ea2
Update user guide
SaschaCowley Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions source/globalCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4851,7 +4851,6 @@ def script_cycleSoundSplit(self, gesture: "inputCore.InputGesture") -> None:
"Increases the volume of other applications",
),
category=SCRCAT_AUDIO,
gesture="kb:NVDA+alt+pageUp",
SaschaCowley marked this conversation as resolved.
Show resolved Hide resolved
)
def script_increaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -> None:
appsVolume._adjustAppsVolume(5)
Expand All @@ -4862,7 +4861,6 @@ def script_increaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -
"Decreases the volume of other applications",
),
category=SCRCAT_AUDIO,
gesture="kb:NVDA+alt+pageDown",
)
def script_decreaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -> None:
appsVolume._adjustAppsVolume(-5)
Expand All @@ -4883,7 +4881,6 @@ def script_toggleApplicationsVolumeAdjuster(self, gesture: "inputCore.InputGestu
"Mutes or unmutes other applications",
),
category=SCRCAT_AUDIO,
gesture="kb:NVDA+alt+delete",
)
def script_toggleApplicationsMute(self, gesture: "inputCore.InputGesture") -> None:
appsVolume._toggleAppsVolumeMute()
Expand Down
8 changes: 3 additions & 5 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@
* Support for math in PDFs has been added.
This works for formulas with associated MathML, such as some files generated by newer versions of TeX/LaTeX.
Currently this is only supported in Foxit Reader & Foxit Editor. (#9288, @NSoiffer)
* Commands to adjust the volume of other applications besides NVDA have been added.
To use this feature, "allow NVDA to control the volume of other applications" must be enabled in the audio settings panel. (#16052, @mltony, @codeofdusk)
* `NVDA+alt+pageUp`: Increase the volume of all other applications.
* `NVDA+alt+pageDown`: Decrease the volume of all other applications.
* `NVDA+alt+delete`: Mute the volume of all other applications.
* The ability to adjust the volume of other applications besides NVDA has been added.
To use this feature, "allow NVDA to control the volume of other applications" must be enabled in the audio settings panel. (#16052, #17634, @mltony, @codeofdusk)
* Added new unassigned gestures to increase, decrease and mute the volume of all other applications.
* When editing in Microsoft PowerPoint text boxes, you can now move per sentence with `alt+upArrow`/`alt+downArrow`. (#17015, @LeonarddeR)
* In Mozilla Firefox, NVDA will report the highlighted text when a URL containing a text fragment is visited. (#16910, @jcsteh)
* NVDA can now report when a link destination points to the current page. (#141, @LeonarddeR, @nvdaes)
Expand Down
14 changes: 3 additions & 11 deletions user_docs/en/userGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2489,24 +2489,16 @@ While [audio ducking](#SelectSynthesizerDuckingMode) does change the volume of o
##### Volume of other applications {#OtherAppVolume}

This slider allows you to adjust the volume of all currently running applications other than NVDA.
This volume can also be controlled via the following keyboard commands from anywhere:

| Name | Key | Description |
|---|---|---|
| Increase volume of other applications | `NVDA+alt+pageUp` | Increases the volume of all applications except NVDA. |
| Decrease volume of other applications | `NVDA+alt+pageDown` | Decreases the volume of all applications except NVDA. |
To increase or decrease the volume of all currently running applications from anywhere, please assign custom gestures using the [Input Gestures dialog](#InputGestures).

##### Mute other applications {#OtherAppMute}

This check box allows you to mute or unmute all applications except NVDA at once.

The following keyboard command can also be used from anywhere:

| Name | Key | Description |
|---|---|---|
| Mute or unmute other applications | `NVDA+alt+delete` | Toggles mute/unmute on other applications |
To mute or unmute all other applications from anywhere, please assign a custom gesture using the [Input Gestures dialog](#InputGestures).

Please note, that this option is not persistent: other apps will always be unmuted when NVDA restarts.
Please note that this option is not persistent: other apps will always be unmuted when NVDA restarts.

##### Time to keep audio device awake after speech {#AudioAwakeTime}

Expand Down
Loading