Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to SAPI5 #17622

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Small fixes to SAPI5 #17622

merged 1 commit into from
Jan 15, 2025

Conversation

gexgd0419
Copy link
Contributor

Link to issue number:

None

Summary of the issue:

Some small fixes to the SAPI5 code part that I wrote. Those things didn't cause crashes or obvious errors, so they slipped by.

Description of user facing changes

None

Description of development approach

plibNewPosition is a pointer, so writing to plibNewPosition->QuadPart should be plibNewPosition[0].QuadPart in Python. This is now corrected.

synth.player.idle() is moved to before the "trigger all untriggered bookmarks" part, to let the audio and the contained bookmarks finish first.

Testing strategy:

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@gexgd0419 gexgd0419 requested a review from a team as a code owner January 14, 2025 07:48
@gexgd0419 gexgd0419 requested a review from seanbudd January 14, 2025 07:48
@seanbudd seanbudd merged commit 0a31499 into nvaccess:master Jan 15, 2025
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Jan 15, 2025
@gexgd0419 gexgd0419 deleted the sapi5-small-fix branch January 15, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants