Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of accidentally f-less f-strings in MessageDialog #17615

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

SaschaCowley
Copy link
Member

Link to issue number:

None

Summary of the issue:

A couple of strings introduced in the message dialog API work were supposed to be f-strings, but the f prefix was missed, making them string literals.

Description of user facing changes

Description of development approach

Changed the erroneous strings to f-strings.

Testing strategy:

Created a MessageDialog in the python console and ensured the debug and exception messages were output correctly.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley marked this pull request as ready for review January 13, 2025 00:32
@SaschaCowley SaschaCowley requested a review from a team as a code owner January 13, 2025 00:32
@SaschaCowley SaschaCowley requested a review from seanbudd January 13, 2025 00:32
@SaschaCowley SaschaCowley changed the title Fx a couple of accidentally f-less f-strings in MessageDialog Fix a couple of accidentally f-less f-strings in MessageDialog Jan 13, 2025
@SaschaCowley SaschaCowley merged commit be58ca5 into master Jan 13, 2025
5 checks passed
@SaschaCowley SaschaCowley deleted the fixMessageDialogFstrings branch January 13, 2025 03:43
@github-actions github-actions bot added this to the 2025.1 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants