Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos related to MessageDialog API #17612

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

nvdaes
Copy link
Collaborator

@nvdaes nvdaes commented Jan 12, 2025

  • Fix typo in _modalDialogOpenCallback method
  • Developer guide: fix capitalization for ReturnCode in confirm meth of MessageDialog documentation

Link to issue number:

None

Summary of the issue:

When a modal message dialog is open and we tried to use blocked actions like opening the NVDA's menu or the exit dialog, an error is raised

Description of user facing changes

Description of development approach

  • Fixed tipo in _modalDialogOpenCallback method of source/gui/blockAction.py.
  • Additionally, fixed capitalization of the confirm method in the developer guide.

Testing strategy:

Tested locally with clipContentsDesigner add-on, version 45.0.1 (dev channel), and opening message dialogs in the Python console, trying to activate the NVDA's menu or the exit dialog.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@nvdaes nvdaes changed the title fixMessageDialogTypos Fix typos related to MessageDialog API Jan 12, 2025
@AppVeyorBot
Copy link

See test results for failed build of commit dd286fcb47

@nvdaes nvdaes requested a review from SaschaCowley January 12, 2025 07:03
@nvdaes nvdaes marked this pull request as ready for review January 12, 2025 07:04
@nvdaes nvdaes requested a review from a team as a code owner January 12, 2025 07:04
@nvdaes
Copy link
Collaborator Author

nvdaes commented Jan 12, 2025

@SaschaCowley , I think that failure in system tests is not related to this PR.

Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nvdaes

@SaschaCowley SaschaCowley merged commit 98455b0 into nvaccess:master Jan 12, 2025
4 of 5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants