-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc to beta #17551
Rc to beta #17551
Conversation
* Added changes section * Bumped minor version
…17526) Partially fixes #17518 Summary of the issue: Some HumanWare devices do not report the number of cells in their HID capabilities report. This is the case for Brailliant BI 40X since firmware 2.4. Description of user facing changes The Brailliant BI 40X and similar display with firmware version 2.4 is working correctly again. Description of development approach This PR fixes the issue by using the HID output report size to calculate the number of cells. If the device reports a cell count, this is still being used. Testing strategy: Tested with a Brailliant BI 40X over Bluetooth. Known issues with pull request: Since firmware 2.4 this device is recognized by the Standard HID driver over Bluetooth. However, the keys do not work using that driver. This PR does not fix the Standard HID driver.
Fixes #17421 Summary of the issue: Chromium-browsers were changed to return E_NOTIMPL and broke speech and braille of all math equations (i.e., no speech or braille for math) in those browsers because NVDA passes along a 'not implemented' COM exception. Description of user facing changes This restores the behavior of NVDA (i.e., math reads) as before the change. Description of development approach A try/except block is added around the call. If the error is E_NOTIMPL, the code moves on as before. Otherwise, the error is re-raised as before.
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces changes across multiple files in the NVDA project. The modifications include improved error handling for MathML attribute retrieval in web accessibility, enhanced initialization logic for Braille display drivers, a minor version number update, and documentation of new features and improvements. The changes aim to improve the robustness and functionality of the NVDA screen reader, with a focus on better error management and device support. Changes
Sequence DiagramsequenceDiagram
participant Math Class
participant COM Interface
participant Error Handler
Math Class->>COM Interface: Attempt to get MathML
alt MathML retrieval successful
COM Interface-->>Math Class: Return MathML
else MathML not implemented
COM Interface-->>Error Handler: Raise E_NOTIMPL
Error Handler->>Math Class: Set attribute to None
else Other COM Error
COM Interface-->>Error Handler: Raise COMError
Error Handler->>Error Handler: Log debug warning
Error Handler->>Error Handler: Re-raise exception
end
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Summary by CodeRabbit
New Features
Bug Fixes
Version Update