Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge rc to beta #17353

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Merge rc to beta #17353

merged 1 commit into from
Nov 4, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Nov 4, 2024 •
edited by coderabbitai bot
Loading

Merge rc to beta

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for the new HID Braille specification for better Braille display compatibility.
    • Introduced "on-demand" speech mode to enhance user control over speech output.
    • Enhanced support for Windows 10 features, including emoji input and dictation.
    • Automatic reporting of screen orientation and battery status.
    • Improved formatting, color, and annotation reporting in Microsoft Office.
    • Performance and stability enhancements across various applications.

  • Bug Fixes

    • Resolved issues related to symbol processing and loading based on locale.

@seanbudd
Provide speech symbols file name path on creation (#17346)
d21c8ba 
Fixes #17344

Summary of the issue:
The SpeechSymbols only sets the filename to write to when the dictionary is loaded.
Before 826ef91, dictionary files were always loaded before they were saved.
Afterwards, dictionaries are saved without being loaded.
When trying to save dictionary files the following error occurs, due to no file name being set

Speaking [LangChangeCommand ('en_US'), 'pressed']
ERROR - unhandled exception (17:00:20.842) - MainThread (9964):
Traceback (most recent call last):
  File "gui\settingsDialogs.pyc", line 5350, in onOk
  File "characterProcessing.pyc", line 364, in save
ValueError: No file name
Description of user facing changes
Users can now save the speech dictionary dialog.
Add-ons which use custom speech dictionaries are also saved correctly now.

Description of development approach
Create optional parameter to set filename path for speech dictionaries.
@seanbudd seanbudd requested a review from a team as a code owner November 4, 2024 00:34
@seanbudd seanbudd requested a review from SaschaCowley November 4, 2024 00:34
@seanbudd seanbudd merged commit f4c028b into beta Nov 4, 2024
2 of 6 checks passed
@seanbudd seanbudd changed the title Provide speech symbols file name path on creation (#17346) Merge rc to beta Nov 4, 2024
@github-actions github-actions bot added this to the 2025.1 milestone Nov 4, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request includes modifications to several files, primarily focusing on version updates and enhancements to the SpeechSymbols and SymbolDictionaryDefinition classes for better configurability. The version_minor variable in buildVersion.py is incremented from 0 to 1. In characterProcessing.py, the SpeechSymbols constructor is updated to accept an optional filename parameter, allowing for locale-specific symbol loading. Additionally, changes.md documents significant new features and improvements, including support for Braille displays, new speech modes, and enhancements in Microsoft Office reporting.

Changes

File Change Summary
source/buildVersion.py Updated version_minor from 0 to 1.
source/characterProcessing.py - Updated SpeechSymbols constructor to accept an optional filename parameter.
- Modified _initSymbols method in SymbolDictionaryDefinition to use locale-specific path.
user_docs/en/changes.md Documented new features: HID Braille support, on-demand speech mode, Windows 10 features, and improvements in reporting.

Possibly related PRs

Suggested reviewers

  • LeonarddeR
  • nvdaes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
1 participant
@seanbudd