Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide speech symbols file name path on creation #17346

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Provide speech symbols file name path on creation #17346

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f40c93c
Provide speech symbols file name path on creation
seanbudd Nov 1, 2024
b7c2fa4
bump version and change log
seanbudd Nov 1, 2024
1280f0d
Update user_docs/en/changes.md
seanbudd Nov 1, 2024
0ec4ca8
Update user_docs/en/changes.md
seanbudd Nov 1, 2024
2adf047
Update user_docs/en/changes.md
seanbudd Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/buildVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def formatVersionForGUI(year, major, minor):
name = "NVDA"
version_year = 2024
version_major = 4
version_minor = 0
version_minor = 1
version_build = 0 # Should not be set manually. Set in 'sconscript' provided by 'appVeyor.yml'
version = _formatDevVersionString()
publisher = "unknown"
Expand Down
6 changes: 3 additions & 3 deletions source/characterProcessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,11 @@ class SpeechSymbols:
This is all handled by L{SpeechSymbolProcessor}.
"""

def __init__(self):
def __init__(self, filename: str | None = None):
"""Constructor."""
self.complexSymbols = collections.OrderedDict()
self.symbols = collections.OrderedDict()
self.fileName = None
self.fileName = filename

def load(self, fileName: str, allowComplexSymbols: bool = True) -> None:
"""Load symbol information from a file.
Expand Down Expand Up @@ -826,7 +826,7 @@ def getSymbols(self, locale: str) -> SpeechSymbols:

def _initSymbols(self, locale: str) -> SpeechSymbols:
raiseOnError = self.source != _SymbolDefinitionSource.USER
symbols = SpeechSymbols()
symbols = SpeechSymbols(self.path.format(locale=locale))
if locale not in self.availableLocales:
msg = f"No {self.name!r} data for locale {locale!r}"
if raiseOnError:
Expand Down
9 changes: 9 additions & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# What's New in NVDA

## 2024.4.1

This patch release includes a fix for Outlook on certain Windows 10 systems.
seanbudd marked this conversation as resolved.
Show resolved Hide resolved
It also includes a fix for saving speech symbol dictionaries.

### Bug fixes

* Fixed bug where speech symbols dictionaries were not saved and the dialog would not be closed. (#17344)

## 2024.4

This release includes a number of improvements in Microsoft Office, braille, and document formatting.
Expand Down