Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating copying.txt using copying.md #17196

Closed
wants to merge 2 commits into from

Conversation

dpy013
Copy link
Contributor

@dpy013 dpy013 commented Sep 20, 2024

Link to issue number:

follow up #16830

Summary of the issue:

In pr 16830
copying.txt The markdown syntax has been used

Description of user facing changes

No user changes

Description of development approach

First the format of copying.txt was updated using copying.md
Secondly, also update the copying.txt reference in pyproject.toml to copying.md

Testing strategy:

Need to see if appveyor can be built successfully

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@dpy013 dpy013 requested a review from a team as a code owner September 20, 2024 03:43
@dpy013 dpy013 requested a review from seanbudd September 20, 2024 03:43
@dpy013 dpy013 marked this pull request as draft September 20, 2024 03:44
@seanbudd
Copy link
Member

You'd also have to update every reference in NVDA, particularly copyright headers, to use the new file name / link. I don't think this is a good idea for now

@dpy013 dpy013 closed this Sep 20, 2024
@dpy013 dpy013 deleted the copying-to-md branch September 20, 2024 03:47
@XLTechie
Copy link
Collaborator

XLTechie commented Sep 20, 2024 via email

@seanbudd
Copy link
Member

seanbudd commented Sep 20, 2024 via email

@XLTechie
Copy link
Collaborator

XLTechie commented Sep 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants