Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beta to master #17150

Merged
merged 1 commit into from
Sep 10, 2024
Merged

beta to master #17150

merged 1 commit into from
Sep 10, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 10, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Improved language extraction from localized .xliff files by using the directory structure instead of file names, enhancing the accuracy of language identification.

  • Bug Fixes

    • Resolved potential issues with language processing related to file naming conventions, ensuring more reliable localization handling.

@michaelDCurran
sconstruct: correctly detect the language of xliff files when trying …
d8d8eb9 
…to skip English (#17143)

Summary of the issue:
The NVDA build system creates html from markdown files. For any language other than English, these markdown files should be themselves generated from xliff files.
However, a rather strange and incorrect line of code caused this to also happen for English, as the line was not correctly detecting the language.

Description of user facing changes
English user documentation in alpha builds should be based on the very latest markdown files, rather than the last beta from the previous release.
@seanbudd seanbudd requested a review from a team as a code owner September 10, 2024 04:20
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the method for extracting the language from the path of localized .xliff files. The previous approach used the file name to determine the language, while the new implementation retrieves the language from the last component of the directory path containing the .xliff file. This change shifts the logic for language identification from the file name to the directory structure.

Changes

File(s) Change Summary
sconstruct Updated language extraction method from file name to directory name.

Tip

Review status comment

The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.

New review model

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seanbudd seanbudd merged commit a4ebfcd into master Sep 10, 2024
2 of 6 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
2 participants
@seanbudd @michaelDCurran