Fix popup menu item reading on Thunderbird #17130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this ready for review? |
Summary of the issue: When the user finds text on Thunderbird by pressing CONTROL+K, searching the text and activating one of the links, NVDA speaks only "section". Description of user facing changes NVDA will speak the popup menu item name correctly. Description of developer facing changes None. Description of development approach Added a check if the object 's name is empty, and is of the "div" tag and has a class of "popup-menuitem", NVDA replaces its name with the name of its child. Testing strategy: Performed a manual test with Thunderbird.
thgcode
force-pushed
the
fix/thunderbird-find
branch
from
8dfb92c to
075006d
Compare
seanbudd
added
the
conceptApproved
seanbudd
reviewed
Sep 10, 2024
Co-authored-by: Sean Budd <[email protected]>
seanbudd
approved these changes
Sep 15, 2024
|
Thanks for your contribution @thgcode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
closes #4708 .
Summary of the issue:
When the user finds text on Thunderbird by pressing CONTROL+K, searching the text and activating one of the links, NVDA speaks only "section".
Description of user facing changes
NVDA will speak the popup menu item name correctly.
Description of development approach
Added a check if the object 's name is empty, and is of the "div" tag and has a class of "popup-menuitem", NVDA replaces its name with the name of its child.
Testing strategy:
Performed manual tests with Thunderbird 128.2.0 and 102.6.0.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary