Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up changes #17072

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix up changes #17072

merged 1 commit into from
Aug 28, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Aug 28, 2024

Fixup changes from #17007

Summary by CodeRabbit

  • New Features

    • Enhanced NVDA support for Mozilla Firefox allows reporting of highlighted text when accessing URLs with text fragments.
    • Added native support for the Dot Pad tactile graphics device as a multiline braille display.
  • Bug Fixes

    • Improved interaction in Microsoft Word and Excel with the ability to browse comments and notes easily.
    • NVDA now reports font attributes in speech and braille separately.
    • Configurable timeout for multiple keypresses to assist users with dexterity impairments.
  • Documentation

    • Updated documentation to reflect new features and improvements, ensuring clarity for users.
    • Removed the feature related to automatic speaking of characters during braille cursor routing based on user feedback.

@seanbudd seanbudd requested a review from a team as a code owner August 28, 2024 07:10
@seanbudd seanbudd requested a review from SaschaCowley August 28, 2024 07:10
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The documentation for NVDA has been updated to include new features, bug fixes, and adjustments relevant to developers. Notable changes include enhanced text reporting in Mozilla Firefox, native support for the Dot Pad tactile graphics device, improved comment and note interactions in Microsoft Office, configurable keypress timeouts, and the removal of the automatic speaking feature for braille cursor routing.

Changes

Files Change Summary
user_docs/en/changes.md Updated documentation to include enhancements in Firefox, native support for Dot Pad, bug fixes in Microsoft Office, configurable keypress timeout, and removal of braille cursor routing feature.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NVDA
    participant Firefox
    participant DotPad

    User->>Firefox: Access URL with text fragment
    Firefox->>NVDA: Highlighted text detected
    NVDA-->>User: Report highlighted text

    User->>Microsoft Word: Press comment command
    Microsoft Word->>NVDA: Display comments
    NVDA-->>User: Show browsable message

    User->>DotPad: Use as multiline braille display
    DotPad-->>NVDA: Support for braille output
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seanbudd seanbudd merged commit dc5f7b9 into master Aug 28, 2024
1 of 3 checks passed
@seanbudd seanbudd deleted the fixChanges branch August 28, 2024 07:10
@github-actions github-actions bot added this to the 2025.1 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant