Merge rc to beta

[seanbudd]

Merges in #17055

Fixes #17036

Summary by CodeRabbit

• New Features

  • Enhanced GUI responsiveness by updating the method for displaying dialogs during addon update checks.

• Bug Fixes

  • Resolved an issue causing the application to freeze during automatic addon update checks under poor network conditions, improving stability and user experience.

• Documentation

  • Added release notes for version 2024.3.1, detailing recent improvements and bug fixes.

[coderabbitai]

Walkthrough

The changes involve modifications to the NVDA application aimed at enhancing the responsiveness of the GUI during automatic add-on update checks. Key updates include switching to a daemon thread for scheduling background jobs and ensuring that modal dialog displays do not block the main thread during update checks, particularly under poor network conditions.

Changes

Files	Change Summary
source/gui/addonStoreGui/__init__.py	Changed the threading model from ThreadTarget.GUI to ThreadTarget.DAEMON in initialize.
source/gui/addonStoreGui/controls/messageDialogs.py	Wrapped displayDialogAsModal call in wx.CallAfter for asynchronous execution.
user_docs/en/changes.md	Added a new section for version 2024.3.1, detailing a bug fix for application freezing during update checks.

Assessment against linked issues

Objective	Addressed	Explanation
NVDA is unresponsive/blocking during the timeout period when the update add-on notifies the connection server. (#17036)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SaschaCowley]

Can you please update the version in buildVersion.py?

[seanbudd]

Can you please update the version in buildVersion.py?

It's there on rc: 6ec1c74, however we don't want to update this on beta.

[SaschaCowley]

This solution does not work for me: I follow your test steps and NVDA still freezes while checking for updates. I have double-checked and I am running the version with the check on the daemon thread.