Update eSpeak-NG to 1.54-dev commit 961454ff #16976
Conversation
WalkthroughThe recent updates primarily focus on enhancing the eSpeak module within NVDA. Key changes include an update to the eSpeak library version and the addition of support for two new languages—Faroese and Xextan. Additionally, command-line options for configuration during updates are now effectively respected, improving the overall user experience. These modifications collectively enhance NVDA's functionality and accessibility. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
nvdaHelper/espeak/sconscript (1)
377-383: Missing input files for new language dictionariesThe expected input files for the Faroese (
fo_list,fo_rules) and Xextan (xex_list,xex_rules) dictionaries are not present in the repository. Please verify the existence and correct naming of these files to ensure the new language support functions as intended.
- Ensure files
fo_list,fo_rules,xex_list, andxex_rulesare added to the repository.Analysis chain
New language dictionaries added.
The
fo_dictandxex_dictentries have been correctly added to support Faroese and Xextan languages.Ensure that the input files
fo_list,fo_rules,xex_list, andxex_rulesexist and are correctly specified.Also applies to: 950-956
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of input files for Faroese and Xextan dictionaries. # Test: Check for the presence of required input files for the new language dictionaries. expected_files=("fo_list" "fo_rules" "xex_list" "xex_rules") for file in "${expected_files[@]}"; do if ! fd --type f --glob "$file"; then echo "Missing file: $file" fi doneLength of output: 330
Script:
#!/bin/bash # Description: Broad search for files related to Faroese and Xextan dictionaries. # Test: Search for any files that might correspond to the expected input files for the new language dictionaries. expected_patterns=("fo_*" "xex_*") for pattern in "${expected_patterns[@]}"; do echo "Searching for files matching: $pattern" fd --type f --glob "$pattern" doneLength of output: 339
Link to issue number:
Closes #16775
Summary of the issue:
eSpeak needs to be updated for 2024.4.
Description of user facing changes
Added languages Faroese and Xextan to eSpeak-NG.
Description of development approach
Followed the update instructions.
Testing strategy:
Rebuilt NVDA from source. Ran NVDA, switched synth to eSpeak-NG. Tested that speech output worked fine in English. Switched voice to Faroese and Xextan and ensured that there was still output.
Known issues with pull request:
None.
Code Review Checklist:
Summary by CodeRabbit