Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta to master #16928

Merged
merged 16 commits into from
Jul 30, 2024
Merged

Beta to master #16928

merged 16 commits into from
Jul 30, 2024

Conversation

seanbudd
Copy link
Member

@coderabbitai ignore

NVDA translation automation and others added 16 commits July 26, 2024 00:01
From translation svn revision: 82771

Authors:
Fatma Mehanna <[email protected]>
Shaimaa Ibrahim <[email protected]>
Abdelkrim Bensaid <[email protected]>
Omar Alojaimi <[email protected]>

Stats:
105	26	user_docs/ar/userGuide.md
 1 file changed, 105 insertions(+), 26 deletions(-)
From translation svn revision: 82771

Authors:
Zahari Yurukov <[email protected]>
Kostadin Kolev <[email protected]>

Stats:
102	0	user_docs/bg/changes.md
104	16	user_docs/bg/userGuide.md
 2 files changed, 206 insertions(+), 16 deletions(-)
From translation svn revision: 82771

Authors:
Daniel K. Gartmann <[email protected]>
Nicolai Svendsen <[email protected]>
[email protected]

Stats:
26	9	user_docs/da/userGuide.md
 1 file changed, 26 insertions(+), 9 deletions(-)
From translation svn revision: 82771

Authors:
Juan C. buno <[email protected]>
Noelia Martinez <[email protected]>
Remy Ruiz <[email protected]>
Jose M. Delicado <[email protected]>

Stats:
2	1	user_docs/es/changes.md
 1 file changed, 2 insertions(+), 1 deletion(-)
From translation svn revision: 82771

Authors:
Juan C. buno <[email protected]>
Ivan Novegil <[email protected]>
Javier Curras <[email protected]>
Jose M. Delicado <[email protected]>

Stats:
2	1	user_docs/gl/changes.md
 1 file changed, 2 insertions(+), 1 deletion(-)
From translation svn revision: 82771

Authors:
Takuya Nishimoto <[email protected]>
Minako Nonogaki <[email protected]>

Stats:
103	1	user_docs/ja/changes.md
2	2	user_docs/ja/userGuide.md
 2 files changed, 105 insertions(+), 3 deletions(-)
From translation svn revision: 82771

Authors:
Joseph Lee <[email protected]>
Chang-Hwan Jang <[email protected]>
Dong Hee Park <[email protected]>
Stanley Chung <[email protected]>

Stats:
101	0	user_docs/ko/changes.md
18	9	user_docs/ko/userGuide.md
 2 files changed, 119 insertions(+), 9 deletions(-)
From translation svn revision: 82771

Authors:
Zvonimir Stanecic <[email protected]>
Aleksandr Lin'kov <[email protected]>

Stats:
89	89	user_docs/ru/changes.md
1	1	user_docs/ru/userGuide.md
 2 files changed, 90 insertions(+), 90 deletions(-)
From translation svn revision: 82771

Authors:
Cagri Dogan <[email protected]>

Stats:
103	0	user_docs/tr/changes.md
102	14	user_docs/tr/userGuide.md
 2 files changed, 205 insertions(+), 14 deletions(-)
From translation svn revision: 82771

Authors:
Dang Hoai Phuc <[email protected]>
Nguyen Van Dung <[email protected]>

Stats:
87	0	user_docs/vi/changes.md
105	17	user_docs/vi/userGuide.md
 2 files changed, 192 insertions(+), 17 deletions(-)
From translation svn revision: 82771

Authors:
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Stats:
1	1	user_docs/zh_CN/userGuide.md
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 82771

Authors:
[email protected]
[email protected]
Aaron Wu <[email protected]>
Victor Cai <[email protected]>
[email protected]

Stats:
196	163	source/locale/zh_TW/characterDescriptions.dic
28	2	source/locale/zh_TW/symbols.dic
 2 files changed, 224 insertions(+), 165 deletions(-)
From translation svn revision: 82771
…n to factory defaults when using the NVDA+control+r command (#16919)

fixes #16896

Summary of the issue:
Sometimes, when pressing the NVDA+control+r command three times, NVDA wouldn't reset the configuration to factory defaults, but instead produce the following error
ERROR - keyboardHandler.internal_keyDownEvent (10:14:40.187) - winInputHook (13232):
internal_keyDownEvent
Traceback (most recent call last):
File "keyboardHandler.pyc", line 245, in internal_keyDownEvent
File "inputCore.pyc", line 535, in executeGesture
AttributeError: 'NoneType' object has no attribute 'suppressClearBrailleRegions'

Description of user facing changes
The user will reliably be able to reset the configuration to factory defaults with the NVDA+control+r command

Description of development approach
the suppressCancelSpeech function is only defined and called if braille.handler is not None, otherwise, speech.cancelSpeech is called
@seanbudd seanbudd requested a review from a team as a code owner July 30, 2024 05:58
@seanbudd seanbudd requested a review from gerald-hartig July 30, 2024 05:58
@seanbudd seanbudd merged commit 24a7261 into master Jul 30, 2024
1 of 3 checks passed
@LeonarddeR
Copy link
Collaborator

For reference, this didn't lint correctly as far as I can see. We should ensure that the linter/formatter runs on beta to master and master to beta merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants